Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load before/after.{solutionName}.sln.targets for .slnx #11535

Merged
merged 3 commits into from
Mar 7, 2025

Conversation

surayya-MS
Copy link
Member

@surayya-MS surayya-MS commented Mar 4, 2025

Fixes #11288

Context

see the issue description #11288

Changes Made

  1. Load before/after.{solutionName}.sln.targets for .slnx
  2. Added test checking that targets from these files are included in the project for .sln and .slnx

Testing

Added tests, tested manually

Notes

added test checking that targets from these files are included in the project
@surayya-MS surayya-MS enabled auto-merge (squash) March 7, 2025 20:12
@surayya-MS surayya-MS merged commit 00b81e7 into dotnet:main Mar 7, 2025
10 checks passed
@maridematte
Copy link
Member

/backport to vs17.14

Copy link
Contributor

Started backporting to vs17.14: https://github.com/dotnet/msbuild/actions/runs/13788521939

Copy link
Contributor

@maridematte an error occurred while backporting to "vs17.14", please check the run log for details!

Error: @maridematte is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=maridematte

@maridematte
Copy link
Member

/backport to vs17.14

Copy link
Contributor

Started backporting to vs17.14: https://github.com/dotnet/msbuild/actions/runs/13788840485

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load after.{SolutionName}.sln.targets for slnx solutions
4 participants