Fix CustomAnalyzer invocation #10473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the_type_of_boolFlags
JanKrivanek
reviewed
Aug 5, 2024
src/Build/BuildCheck/Infrastructure/BuildCheckManagerProvider.cs
Outdated
Show resolved
Hide resolved
JanKrivanek
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10475
Solution
In order to have the analyzer triggered, it had to be registered globally by
SetupSingleAnalyzerinvocation. Since it happens after having build-in rules registered, the separate call is added in RegisterCustomAnalyzer.Notes
Remove extra
RegisterCustomAnalyzer. It seems to be left after unfortunate merge.Testing
Add e2e tests that respect .editorconfig and validate the actual custom analyzer run.