[8.0.4xx] Fix serialization of TelemetryEventArgs data packets across MSBuild worker nodes #10464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
force-pushed
the
fix-telemetry-event-serialization
branch
from
3b07965
to
036459b
Compare
f-alizada
approved these changes
Jul 31, 2024
baronfel
commented
Jul 31, 2024
baronfel
commented
Jul 31, 2024
rainersigwald
approved these changes
Jul 31, 2024
baronfel
changed the title
baronfel
changed the title
14 tasks
This was referenced Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes azdo#2174440
Context
The serialization of telemetry events assumed that telemetry properties would always have a value - it seems like it's possible for callers to send null values, so we need to be able to handle that. This was triggered with the addition of containers telemetry added in 8.0.400.
Changes Made
Optionally write and read the value string for the telemetry event payload.
Testing
Added previously-nonexistent round-tripping tests for this event type.
Notes
We'll want to take this to SDK Tactics for servicing, but then to VS QB to see if they want to align releases or let the VS side drift a bit.