Reapply Support lazy instantiation of ProjectInstance values when CPS Evaluation cache is used #10350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Evaluation cache is used (dotnet#10030)" This reverts commit eade720.
…S Evaluation cache is used (dotnet#10030)" (dotnet#10205) This reverts commit 9bea802.
|
experimental insertion for checking the performance: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/563920 |
|
And yet another exp insertion: https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/567802 (as there were couple failed perf tests in previous that seems as noise to me - comparing to variance of previous main builds) |
JanKrivanek
approved these changes
Jul 27, 2024
There was a problem hiding this comment.
I'm fine with the change:
- For the actual changes I defer to previous reviews (on Support lazy instantiation of ProjectInstance values when CPS Evaluation cache is used #10030)
- All 3 VS insertions haven't showed statistically significant degradation of perf in measured scenarios (there were some cases within variations - non of which showed on more than 1 run).
rainersigwald
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AB#2067934
Context
A previous refactoring for performance optimization introduced a regression in memory usage in vcxprojreader (AB#2067934). Consequently, the new code was reverted until a fix was available. This PR contains the fix and reinstates the performance optimization code.
Changes Made
Testing
Manual verification of the impacted scenario.