-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable localization for vs17.10 #10269
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version. |
rainersigwald
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM though I would by policy recommend taking the version bump (instead of canceling the auto-scheduled build).
f-alizada
approved these changes
Jun 20, 2024
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
This was referenced Jun 26, 2024
AR-May
added a commit
that referenced
this pull request
Jun 28, 2024
Adding a comment about localization in order to cause a merge conflict in the next release branch, when we will be disabling the localization in the previous release branch and the change flows automatically to later releases and main. See #10269 (comment)
AR-May
added a commit
that referenced
this pull request
Jul 2, 2024
Adding a comment about localization in order to cause a merge conflict, when #10269 flows automatically to this branch releases and main. See #10269 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable localization for vs17.10