Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable localization for vs17.10 #10269

Merged
merged 5 commits into from
Jun 26, 2024
Merged

Conversation

AR-May
Copy link
Member

@AR-May AR-May commented Jun 19, 2024

Disable localization for vs17.10

@AR-May AR-May requested a review from a team as a code owner June 19, 2024 16:16
Copy link
Contributor

Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version.

Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though I would by policy recommend taking the version bump (instead of canceling the auto-scheduled build).

.vsts-dotnet.yml Outdated Show resolved Hide resolved
.vsts-dotnet.yml Outdated Show resolved Hide resolved
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
@AR-May AR-May merged commit 7d15f33 into dotnet:vs17.10 Jun 26, 2024
10 checks passed
AR-May added a commit that referenced this pull request Jun 28, 2024
Adding a comment about localization in order to cause a merge conflict in the next release branch, when we will be disabling the localization in the previous release branch and the change flows automatically to later releases and main.

See #10269 (comment)
AR-May added a commit that referenced this pull request Jul 2, 2024
Adding a comment about localization in order to cause a merge conflict, when #10269 flows automatically to this branch releases and main. 

See #10269 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants