Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server: Flush console output periodically #10231

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Server: Flush console output periodically #10231

merged 1 commit into from
Jun 17, 2024

Commits on Jun 17, 2024

  1. Manual thread safety in RedirectConsoleWriter 

    Initially, this delegated thread safety to a `SyncTextWriter`, but the
object graph was hard to understand, so it was replaced with a has-a
`SyncTextWriter` relationship, but this lost the timer-based call to
`Flush()` to send the output to the client.

The docs on `MethodImplOptions.Synchronized` also advise that it can be
risky due to locking on the object itself, so manage the syncronization
with an explicit lock object over the underlying `StringWriter` instead.
    @rainersigwald
    rainersigwald committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    7310f74 View commit details
    Browse the repository at this point in the history