-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BuildCheck] Implement double writes analyzer #10184
Conversation
9b8cf13
to
bd77da3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I did just a first quick pass - but overall looks good.
I'll do more in depth review early next week
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looks very good!
The only reason I'm requesting changes is the rooting of the path in the AnalyzeWrite
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Awesome work!!!
Fixes #9881
Context
We believe there is value in flagging cases where the same file is written by more than one task during a build. dotnet/source-build#4390 is an example of a recent hard-to-diagnose build issue that could have been prevented by this analyzer.
Changes Made
This PR adds a new built-in analyzer and makes a few supporting changes.
Testing
Notes
The changes contain a fix/workaround for #10176.