Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pack template for custom analyzer #10155

Merged
merged 4 commits into from
May 27, 2024
Merged

pack template for custom analyzer #10155

merged 4 commits into from
May 27, 2024

Conversation

JaynieBai
Copy link
Member

@JaynieBai JaynieBai commented May 20, 2024

Fixes #9915

Context

#9789 added a template for custom analyzer.
In order for that to be usable by our customers - we need to be publishing this to nuget feed along with our other binaries. So we should have the package produced from our repo - ideally as part of our build script

Changes Made

Create a template package project with property <GeneratePackageOnBuild>true</GeneratePackageOnBuild>that pack the templates into a nuget package when build. Add the package project in the msbuild solution in order to build the project.

Testing

https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=9602998&view=artifacts&pathAsName=false&type=publishedArtifacts in the packageArtifacts folder.

image

Notes

@JaynieBai JaynieBai marked this pull request as ready for review May 20, 2024 08:40
MSBuild.sln Outdated Show resolved Hide resolved
Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JaynieBai JaynieBai changed the title Exp/jenny/packtemplate pack template for custom analyzer May 27, 2024
@JaynieBai JaynieBai merged commit 2d924ca into main May 27, 2024
10 checks passed
@JaynieBai JaynieBai deleted the exp/jenny/packtemplate branch May 27, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pack project or script for the Analyzers authoring template
5 participants