Fix incorrect use of GetOrAdd #10152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method `GetOrAdd` has two overloads with two arguments: ```csharp GetOrAdd(string key, object value); GetOrAdd(string key, Func<string, object> valueFactory); ``` The lambda here does not take an argument hence it's not compatible with `Func<string, object>`. It is compatible with `object` though because a delegate can convert to `object`. This is problematic because there is no guarantee the delegate here is unqiue. The compiler is free to cache instantiations of delegates, particularly ones like this which capture no state. That means different keys could very well be sharing the same value.
rainersigwald
approved these changes
May 17, 2024
jeffkl
approved these changes
May 17, 2024
stephentoub
reviewed
May 17, 2024
stephentoub
approved these changes
May 17, 2024
No 😉 |
|
@rainersigwald, @baronfel i'm not authorized to merge this myself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
GetOrAddhas two overloads with two arguments:The lambda here does not take an argument hence it's not compatible with
Func<string, object>. It is compatible withobjectthough because a delegate can convert toobject.This is problematic because there is no guarantee the delegate here is unqiue. The compiler is free to cache instantiations of delegates, particularly ones like this which capture no state. That means different keys could very well be sharing the same value.
Fixes #
Context
Changes Made
Testing
Notes