[GB18030] Fix SubstringByTextElements - avoid ArgumentOutOfRangeException
#10080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jan Krivanek <krivanek.j@hotmail.com>
JanKrivanek
requested changes
Apr 30, 2024
YuliiaKovalova
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #10063, see the discussion.
Context
The original PR was fixing
GB18030issue but for project names with less text elements than 8 it would be throwing an exception. What's more,SubstringByTextElementsused previously is giving different results for .net framework and .net core, see doc.Changes Made
Fix: do not change project name if it's shorter than 8 chars. Replace non-ASCII chars with underscore
_, cut substring to the desired length.Testing
Automatic test case added.