Fix warning in CustomBuildEventArgs #10070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes badly formatted caution/warning note and links.
Context
An XML doc comment was not rendering properly due to badly formatted Markdown in a CDATA section.
Changes Made
Add proper formatting for warning note.
Change severity level from Caution to Warning (more appropriate for this situation)
Remove redundant third link
Testing
Tested the equivalent fix in the MSBuild API docs repo:
dotnet/msbuild-api-docs#42
Notes
The fix in the API docs repo can be promoted live right away.
The fix here in MSBuild source will take effect once we rebuild the MSBuild API docs XML from source after the next dot release when the NuGet packages are republished.