Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analyzers acquisition experience #10014

Merged
merged 66 commits into from
Apr 25, 2024
Merged

Analyzers acquisition experience #10014

merged 66 commits into from
Apr 25, 2024

Commits on Feb 20, 2024

  1. Initial demonstration version

    @JanKrivanek
    JanKrivanek committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    a59fe1e View commit details
    Browse the repository at this point in the history

  2. Make analyzer test use bootstrap properly (dotnet#9733)

    @JanKrivanek
    JanKrivanek committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    628394d View commit details
    Browse the repository at this point in the history

  3. Hook analyzers stats stub

    @JanKrivanek
    JanKrivanek committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    59ab931 View commit details
    Browse the repository at this point in the history

  4. Fix unit tests by explicitly opting into analysis

    @JanKrivanek
    JanKrivanek committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    92e3795 View commit details
    Browse the repository at this point in the history

  5. Disable build acceleration for MSBuild.Bootstrap

    @ladipro @JanKrivanek
    ladipro authored and JanKrivanek committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    33c4d2e View commit details
    Browse the repository at this point in the history

  6. Make EndToEndTests disposable

    @ladipro @JanKrivanek
    ladipro authored and JanKrivanek committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    b37e495 View commit details
    Browse the repository at this point in the history

  7. Support running Analyzers.UnitTests from stage1

    @ladipro @JanKrivanek
    ladipro authored and JanKrivanek committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    2db509f View commit details
    Browse the repository at this point in the history

  8. Fix MSBuild.dll casing

    @ladipro @JanKrivanek
    ladipro authored and JanKrivanek committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    4cdd903 View commit details
    Browse the repository at this point in the history

  9. Don't run netfx Analyzer.UnitTests in Windows Core builds

    @ladipro @JanKrivanek
    ladipro authored and JanKrivanek committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    05450bb View commit details
    Browse the repository at this point in the history

  10. Fix Analyzers.UnitTests on Mac

    @ladipro @JanKrivanek
    ladipro authored and JanKrivanek committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    7e12ef0 View commit details
    Browse the repository at this point in the history

  11. Renaming changes

    @JanKrivanek
    JanKrivanek committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    fdda2cd View commit details
    Browse the repository at this point in the history

  12. Renaming for clarity (dotnet#9754)

    @JanKrivanek
    JanKrivanek committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    72749c4 View commit details
    Browse the repository at this point in the history

  13. Removing unnecessary types

    @JanKrivanek
    JanKrivanek committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    9314121 View commit details
    Browse the repository at this point in the history

  14. Code move

    @JanKrivanek
    JanKrivanek committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    886c483 View commit details
    Browse the repository at this point in the history

  15. Adjust namespaces

    @JanKrivanek
    JanKrivanek committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    60e01a7 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Simplify TestEnvironments in EndToEndTests

    @ladipro
    ladipro committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    b474fa1 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Support for per-project configuration, Acquisition mounting, etc

    @JanKrivanek
    JanKrivanek committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    ac76b77 View commit details
    Browse the repository at this point in the history

  2. Add more comments

    @JanKrivanek
    JanKrivanek committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    0467261 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Grace handle double initialization attempts

    @JanKrivanek
    JanKrivanek committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    5f9d941 View commit details
    Browse the repository at this point in the history

  2. Fix tests

    @JanKrivanek
    JanKrivanek committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    40dd6e0 View commit details
    Browse the repository at this point in the history

  3. Troubleshoot test, comment

    @JanKrivanek
    JanKrivanek committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    bddef4c View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Reflect PR comments

    @JanKrivanek
    JanKrivanek committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    296faa9 View commit details
    Browse the repository at this point in the history

  2. Fix build

    @JanKrivanek
    JanKrivanek committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    f873eda View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Fix build - proper multitargeting on core builds

    @JanKrivanek
    JanKrivanek committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    3db5e97 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Adjust API naming and exposure

    @JanKrivanek
    JanKrivanek committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    6021771 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Merge branch 'main' into exp/build-analyzers

    @JanKrivanek
    JanKrivanek committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    72f2d51 View commit details
    Browse the repository at this point in the history

  2. Add forgotten acquisition data sending

    @JanKrivanek
    JanKrivanek committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    178907f View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Renaming BuildCop to BuildCheck (dotnet#9893) 

    We decided to rename the analyzer project from BuildCop to BuildCheck. This PR is just reflecting that on the code.
    @maridematte
    maridematte committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    e178918 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Renamed a few files missed (dotnet#9900)

    @maridematte
    maridematte committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    0892e86 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Add template for custom analyzers (dotnet#9789)

    @YuliiaKovalova
    YuliiaKovalova committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    31a2a0e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into exp/build-analyzers

    @JanKrivanek
    JanKrivanek committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    d710e00 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. init changes

    @YuliiaKovalova
    YuliiaKovalova committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    2aeda7e View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. Run tests against just-built bootstrap environment

    @ladipro
    ladipro committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    5fab936 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Reflecting PR comments

    @JanKrivanek
    JanKrivanek committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    9b5b925 View commit details
    Browse the repository at this point in the history

  2. Add test without analysis

    @JanKrivanek
    JanKrivanek committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    d97a611 View commit details
    Browse the repository at this point in the history

  3. Rename tests project

    @JanKrivanek
    JanKrivanek committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    e18f00f View commit details
    Browse the repository at this point in the history

  4. Force case renaming

    @JanKrivanek
    JanKrivanek committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    368cb08 View commit details
    Browse the repository at this point in the history

  5. pass logging context to inrinsic function

    @YuliiaKovalova
    YuliiaKovalova committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    e1112be View commit details
    Browse the repository at this point in the history

  6. merge

    @YuliiaKovalova
    YuliiaKovalova committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    e721c0a View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Simplify GlobalInstance initialization

    @JanKrivanek
    JanKrivanek committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    7025f3a View commit details
    Browse the repository at this point in the history

  2. Remove multiple registrations checking

    @JanKrivanek
    JanKrivanek committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    aeb4107 View commit details
    Browse the repository at this point in the history

  3. Reflect on PR feedback

    @JanKrivanek
    JanKrivanek committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    01510e2 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Mariana Dematte <magarces@microsoft.com>
    @JanKrivanek @maridematte
    JanKrivanek and maridematte committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    1d7c4c6 View commit details
    Browse the repository at this point in the history

  5. Reflect on PR comments

    @JanKrivanek
    JanKrivanek committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    25b5f75 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. implement full aquisition flow

    @YuliiaKovalova
    YuliiaKovalova committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    53a7c8b View commit details
    Browse the repository at this point in the history

  2. merge

    @YuliiaKovalova
    YuliiaKovalova committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    5dea8dc View commit details
    Browse the repository at this point in the history

  3. cleanup

    @YuliiaKovalova
    YuliiaKovalova committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    06e06d5 View commit details
    Browse the repository at this point in the history

  4. fix template

    @YuliiaKovalova
    YuliiaKovalova committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    ab744f6 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. add test coverage

    @YuliiaKovalova
    YuliiaKovalova committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    5b86a3d View commit details
    Browse the repository at this point in the history

  2. cleanup

    @YuliiaKovalova
    YuliiaKovalova committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    b73069c View commit details
    Browse the repository at this point in the history

  3. cleanup

    @YuliiaKovalova
    YuliiaKovalova committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    0fdf77f View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Update src/Build/BuildCheck/API/BuildAnalyzerRule.cs 

    Co-authored-by: Farhad Alizada <104755925+f-alizada@users.noreply.github.com>
    @JanKrivanek @f-alizada
    JanKrivanek and f-alizada committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    aaaafcc View commit details
    Browse the repository at this point in the history

  2. Reflect PR comments

    @JanKrivanek
    JanKrivanek committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    cf29add View commit details
    Browse the repository at this point in the history

  3. Merge branch 'exp/build-analyzers' of https://github.com/dotnet/msbuild… 

    … into exp/build-analyzers
    @JanKrivanek
    JanKrivanek committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    402f490 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. merge + fix review comments

    @YuliiaKovalova
    YuliiaKovalova committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    8e04656 View commit details
    Browse the repository at this point in the history

  2. fix test failure

    @YuliiaKovalova
    YuliiaKovalova committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    c7d1b1d View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. fix review comments

    @YuliiaKovalova
    YuliiaKovalova committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    724f1f3 View commit details
    Browse the repository at this point in the history

  2. fix review comments

    @YuliiaKovalova
    YuliiaKovalova committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    3e0b455 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. merge

    @YuliiaKovalova
    YuliiaKovalova committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    086dbea View commit details
    Browse the repository at this point in the history

  2. remove extra file

    @YuliiaKovalova
    YuliiaKovalova committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    dde2231 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. fix review comments

    @YuliiaKovalova
    YuliiaKovalova committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    c5dbb56 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. fix review comments

    @YuliiaKovalova
    YuliiaKovalova committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    0071485 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into dev/ykovalova/analyzers_aquisition_experience

    @YuliiaKovalova
    YuliiaKovalova committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    74d2af9 View commit details
    Browse the repository at this point in the history

  3. Update Strings.resx

    @YuliiaKovalova
    YuliiaKovalova committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    ed8e6a5 View commit details
    Browse the repository at this point in the history

  4. update string resources

    @YuliiaKovalova
    YuliiaKovalova committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    bcb5ba3 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. add one more exception catching layer

    @YuliiaKovalova
    YuliiaKovalova committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    b2d984e View commit details
    Browse the repository at this point in the history