Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ImmutableSegmentedList<T> where appropriate #6601

Closed
sharwell opened this issue Jun 21, 2021 · 0 comments · Fixed by #6595
Closed

Use ImmutableSegmentedList<T> where appropriate #6601

sharwell opened this issue Jun 21, 2021 · 0 comments · Fixed by #6595
Labels
backlog performance triaged
Milestone
VS 17.0

Comments

@sharwell
Copy link
Member

Once implemented, ImmutableSegmentedList<T> should be used where appropriate. This issue tracks TODO comments in source.
@sharwell sharwell added the needs-triage Have yet to determine what bucket this goes in. label Jun 21, 2021
sharwell added a commit to sharwell/msbuild that referenced this issue Jun 21, 2021
@sharwell
Use List<T> to avoid array copies
7e89aeb 
These lists can eventually be converted to ImmutableSegmentedList<T>.
See dotnet#6601.
@rainersigwald rainersigwald added performance and removed needs-triage Have yet to determine what bucket this goes in. labels Jun 21, 2021
@AR-May AR-May added the backlog label Jun 24, 2021
sharwell added a commit to sharwell/msbuild that referenced this issue Jul 30, 2021
@sharwell
Use ImmutableSegmentedList<T> where appropriate
c85cd99 
Closes dotnet#6601
@sharwell sharwell mentioned this issue Jul 30, 2021
Merged
@ladipro ladipro added this to the VS 17.0 milestone Dec 8, 2021
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog performance triaged
Projects
None yet
Milestone
VS 17.0
Development

Successfully merging a pull request may close this issue.

Enable Microsoft.CodeAnalysis.Collections sharwell/msbuild
4 participants
@sharwell @rainersigwald @ladipro @AR-May