Skip to content

Commit

Permalink
Setup UnGAC: treat 259 as success (#9325)
Browse files Browse the repository at this point in the history
One of the top VS Setup failures is a 259 from our UnGAC, even though we
have a big try/catch that should make it never fail. Tell the Setup
engine that 259 is another kind of success to keep this nonblocking.

Fixes AB#1899796.

Co-authored-by: Matt Cavallari <mjcavallari-zz@users.noreply.github.com>
  • Loading branch information
rainersigwald and mjcavallari-zz committed Oct 18, 2023
1 parent 867e260 commit c6f4fc1
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/Package/Microsoft.Build.UnGAC/exe.swr
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,8 @@ vs.installSize

vs.payloads
vs.payload source=$(BinDir)Microsoft.Build.UnGAC.exe

vs.returnCodes
vs.returnCode type=success
exitCode=259
details="Suppress return-code 259 since this is a best-effort ."

0 comments on commit c6f4fc1

Please sign in to comment.