Handle Safe Area on iOS. It's an Opt in via Interface #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartez
approved these changes
Apr 30, 2021
PureWeen
previously requested changes
Apr 30, 2021
| var bounds = Frame.ToRectangle(); | ||
| if(View is ISafeAreaView sav && !sav.IgnoreSafeArea) | ||
| { | ||
| var safe = SafeAreaInsets; |
There was a problem hiding this comment.
I think this needs a check if you're on iOS 10
https://developer.apple.com/documentation/uikit/uiview/2891103-safeareainsets
There was a problem hiding this comment.
Does Maui support prior to iOS 10?
There was a problem hiding this comment.
I added a single RespondsToSelector check, so it will not crash on any OS version.
Clancey
force-pushed
the
Safe-Area
branch
2 times, most recently
from
e7fe802 to
7fe44b9
Compare
rmarinho
pushed a commit
that referenced
this pull request
May 7, 2021
* Handle Safe Area on iOS. It's an Opt in via Interface * Added a check to SafeArea
samhouts
added
area-layout
samhouts
added
the
fixed-in-6.0.100-preview.5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows iOS to handle Safe Area automatically, if you opt into it vie the Interface, ISafeAreaView