Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new Attribute for static methods. [OnHotReload] #833

Merged
merged 2 commits into from
May 5, 2021

Conversation

Clancey
Copy link
Contributor

@Clancey Clancey commented Apr 23, 2021

This allows us to hook into the HotReload for a specific type. This will allow us to register a class or reset defaults when a class is HotReloaded

Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I like this. Simple and sweet, but powerful. Also better than the unit as well as only accessed via reflection meaning it can get linked out.

@jsuarezruiz jsuarezruiz self-requested a review April 27, 2021 12:08
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!.

Just a small change to fix the build:
ReflectionMethodComparer.Equals(MethodInfo g1, MethodInfo g2) in HotReloadExtensions.cs must be ReflectionMethodComparer.Equals(MethodInfo? g1, MethodInfo? g2)
(Nullability checks)

@Clancey Clancey force-pushed the reloadify-on-hot-reload branch from 029f474 to e045f5e Compare May 4, 2021 20:20
@jsuarezruiz jsuarezruiz merged commit 25292d8 into dotnet:main May 5, 2021
@samhouts samhouts added the area-tooling XAML & C# Hot Reload, XAML Editor, Live Visual Tree, Live Preview, Debugging label Jul 19, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2023
@samhouts samhouts added the fixed-in-6.0.100-preview.5 Look for this fix in 6.0.100-preview.5! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-tooling XAML & C# Hot Reload, XAML Editor, Live Visual Tree, Live Preview, Debugging fixed-in-6.0.100-preview.5 Look for this fix in 6.0.100-preview.5!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants