Implement ActivityIndicatorHandler in WinUI #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Happypig375
suggested changes
Apr 22, 2021
| element.SetBinding(GetForegroundProperty(element), binding); | ||
| } | ||
|
|
||
| internal static IEnumerable<T?> GetDescendantsByName<T>(this DependencyObject parent, string elementName) where T : DependencyObject |
There was a problem hiding this comment.
Suggested change
| internal static IEnumerable<T?> GetDescendantsByName<T>(this DependencyObject parent, string elementName) where T : DependencyObject | |
| internal static IEnumerable<T> GetDescendantsByName<T>(this DependencyObject parent, string elementName) where T : DependencyObject |
| return foregroundProperty; | ||
| } | ||
|
|
||
| internal static IEnumerable<T?> GetChildren<T>(this DependencyObject parent) where T : DependencyObject |
There was a problem hiding this comment.
Suggested change
| internal static IEnumerable<T?> GetChildren<T>(this DependencyObject parent) where T : DependencyObject | |
| internal static IEnumerable<T> GetChildren<T>(this DependencyObject parent) where T : DependencyObject |
Co-authored-by: Hadrian Tang <hadrianwttang@outlook.com>
rmarinho
requested changes
Apr 23, 2021
| using System.Linq; | ||
| using System.Reflection; | ||
|
|
||
| namespace Microsoft.Maui |
There was a problem hiding this comment.
Was internal in Xamarin.Forms, should we changed it?, any reason to not be public?
| public static void UpdateIsRunning(this MauiActivityIndicator mauiActivityIndicator, IActivityIndicator activityIndicator) | ||
| { | ||
| // TODO: Use IView Opacity if the ActivityIndicator is running. | ||
| mauiActivityIndicator.ElementOpacity = activityIndicator.IsRunning ? 1 : 0; |
There was a problem hiding this comment.
No other way to do this? @PureWeen any ideas?
|
|
||
| namespace Microsoft.Maui | ||
| { | ||
| public static class FrameworkElementExtensions |
There was a problem hiding this comment.
Do we want this to be public ?
There was a problem hiding this comment.
Was internal in Xamarin.Forms, should we changed it?, any reason to not be public?
|
@rmarinho Fixed the issue you described. |
|
Seem to work fine,
Did some other comments |
rmarinho
approved these changes
May 18, 2021
lytico
pushed a commit
to lytico/maui
that referenced
this pull request
May 20, 2021
* Implement ActivityIndicatorHandler in WinUI * Fix build error * Enable nullable in ActivityIndicatorExtensions * Added nullable enable flag in WinUI ActivityIndicatorHandler * Fix build error * Apply suggestions from code review Co-authored-by: Hadrian Tang <hadrianwttang@outlook.com> * Fix merge * Fixed ResourceDictionary error * Move extensions to be internal Co-authored-by: Rui Marinho <me@ruimarinho.net> Co-authored-by: Hadrian Tang <hadrianwttang@outlook.com>
samhouts
added
the
fixed-in-6.0.100-preview.5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Implement ActivityIndicatorHandler in WinUI.
PR Checklist
Does this PR touch anything that might effect accessibility?
No