Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboard with OneLocBuild Task and Add Security checks #631

Merged
merged 18 commits into from
May 5, 2021
Merged

Conversation

rmarinho
Copy link
Member

@rmarinho rmarinho commented Mar 31, 2021

Description of Change

  • Add pipeline support to use the OneLocBuild task to get translations for our resource files.
  • Remove xliff
  • Add CredScan
  • Add polycheck

Additions made

None

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might effect accessibility?

  • APIs that modify focusability?
  • APIs that modify any text property on a control?
  • Does this PR modify view nesting or view arragement in anyway?
  • Is there the smallest possibility that your PR will change accessibility?
  • I'm not sure, please help me

If any of the above checkboxes apply to your PR then the PR will need to provide testing to demonstrate that accessibility still works.

@rmarinho rmarinho changed the title Onboard with OneLocBuild Task Onboard with OneLocBuild Task and Add Security checks Mar 31, 2021
@rmarinho rmarinho requested a review from mcumming April 7, 2021 10:23
eng/pipelines/common/security_compliance.yml Show resolved Hide resolved
eng/pipelines/common/security_compliance.yml Outdated Show resolved Hide resolved
@rmarinho
Copy link
Member Author

rmarinho commented May 3, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@rmarinho
Copy link
Member Author

rmarinho commented May 5, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@rmarinho rmarinho merged commit da58c1d into main May 5, 2021
@rmarinho rmarinho deleted the oneloc branch May 5, 2021 17:04
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@samhouts samhouts added the fixed-in-6.0.100-preview.5 Look for this fix in 6.0.100-preview.5! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-6.0.100-preview.5 Look for this fix in 6.0.100-preview.5!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants