Increase BlazorWebView test timeouts #4543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Pipelines successfully started running 2 pipeline(s). |
Redth
approved these changes
Feb 7, 2022
TanayParikh
approved these changes
Feb 7, 2022
pranavkm
reviewed
Feb 7, 2022
| @@ -9,8 +9,8 @@ namespace Microsoft.Maui.MauiBlazorWebView.DeviceTests | |||
| { | |||
| public static class WebViewHelpers | |||
| { | |||
| const int MaxWaitTimes = 10; | |||
| const int WaitTimeInMS = 200; | |||
| const int MaxWaitTimes = 30; | |||
There was a problem hiding this comment.
Could we use TimeSpan instead of these?
There was a problem hiding this comment.
Suggested change
| const int MaxWaitTimes = 30; | |
| static readonly TimeSpan MaxWaitTimes = TimeSpan.FromSeconds(30); |
There was a problem hiding this comment.
Many things about how these tests are written could be refactored and cleaned up. The way the timeout is represented is one of the least of the changes :) I know they were originally written only as a proof-of-concept that such tests are possible and can be made to run in CI.
So I'd rather wait until we make the test infrastructure nice here before being concerned with such a detail.
Eilon
approved these changes
Feb 8, 2022
|
I went ahead and merged so that by morning time we can hopefully see if reliability has gone up. Thank you @SteveSandersonMS ! |
samhouts
added
the
fixed-in-6.0.200-preview.14.2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases BlazorWebView test timeouts to 7.5s. Previously they were 500ms (Windows) or 2s (Android/iOS). Hopefully this will mitigate test flakiness, but we have to try it to see.