Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement IsReadOnly in IEntry Handlers #437

Merged
merged 12 commits into from
Mar 10, 2021
Merged

Implement IsReadOnly in IEntry Handlers #437

merged 12 commits into from
Mar 10, 2021

Conversation

almirvuk
Copy link
Contributor

@almirvuk almirvuk commented Mar 5, 2021

Implements #435

  • Adds string IsReadOnly { get; } to the IEntry interface
  • Adds IsReadOnly property map to EntryHandler
  • Adds IsReadOnly mapping methods to EntryHandler for Android and iOS
  • Adds extension methods to apply IsReadOnly on Android/iOS
  • Adds DeviceTests for initial IsReadOnly values on iOS and Android

@almirvuk almirvuk marked this pull request as draft March 5, 2021 18:29
mattleibow
mattleibow reviewed Mar 6, 2021
View reviewed changes
Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another very good one. Thanks!

src/Core/src/Platform/Android/EntryExtensions.cs Outdated Show resolved Hide resolved
src/Core/tests/DeviceTests/Stubs/EntryStub.cs Outdated Show resolved Hide resolved
@mattleibow
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@almirvuk almirvuk requested a review from mattleibow March 7, 2021 09:38
@almirvuk almirvuk marked this pull request as ready for review March 7, 2021 09:38
jsuarezruiz
jsuarezruiz previously requested changes Mar 8, 2021
View reviewed changes
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, it looks great just some small change.

src/Core/src/Core/IEntry.cs Outdated Show resolved Hide resolved
src/Core/tests/DeviceTests/Handlers/Entry/EntryHandlerTests.cs Show resolved Hide resolved
mattleibow
mattleibow approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking wonderful! Thanks for getting this in so quick and making all the changes.

@mattleibow
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mattleibow
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mattleibow mattleibow merged commit fcf3bd7 into dotnet:main Mar 10, 2021
@almirvuk
Copy link
Contributor Author

Another one! Thank you for your time!

@almirvuk almirvuk mentioned this pull request Mar 10, 2021
Closed
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattleibow mattleibow mattleibow approved these changes

@jsuarezruiz jsuarezruiz Awaiting requested review from jsuarezruiz

Assignees
No one assigned
Labels
area-controls-entry Entry platform/android 🤖 platform/iOS 🍎
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@almirvuk @mattleibow @jsuarezruiz @Eilon @samhouts @Redth