-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[net9.0] Revert: Add MauiUIApplicationDelegate remote notification methods #24907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also please rebase, we fixed some tests on net9.0 |
Unfortunately, when these lifecycle events were added, we didn't consider the implications of having the methods implemented on the appdelegate had with Apple app store submissions. Basically if the app delegate implements these methods, Apple assumes in their static analysis of the submitted apps that you intend to use them, and will warn about requiring the appropriate entitlements to therefore be declared. Given there's no obvious/easy way to conditionally export these selectors at this time, we are reverting the change to maintain the no warning/no error submission behaviour. For more information and to track future potential implementations of these lifecycle events, follow: #24237
Redth
force-pushed
the
dev/redth/revert-23452
branch
from
September 24, 2024 18:53
90db641
to
1f3cb3a
Compare
PureWeen
approved these changes
Sep 24, 2024
/rebase |
jfversluis
approved these changes
Sep 25, 2024
samhouts
added
the
fixed-in-net9.0-nightly
This may be available in a nightly release!
label
Oct 1, 2024
Redth
added a commit
to dotnet/docs-maui
that referenced
this pull request
Oct 8, 2024
In previews we had added new app lifecycle events for iOS push notifications, but have removed them from GA since there are potential issues with app store submissions the way they have been added. This change reverts them: dotnet/maui#24907 This issue tracks adding them back in the future: dotnet/maui#24237
davidbritch
added a commit
to dotnet/docs-maui
that referenced
this pull request
Oct 8, 2024
* Remove previously added iOS App Lifecycle events for push In previews we had added new app lifecycle events for iOS push notifications, but have removed them from GA since there are potential issues with app store submissions the way they have been added. This change reverts them: dotnet/maui#24907 This issue tracks adding them back in the future: dotnet/maui#24237 * Remove extra blank line * Also remove events from app lifecycle doc. --------- Co-authored-by: David Britch <davidbritch@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, when these lifecycle events were added in #23452 we didn't consider the implications of having the methods implemented on the appdelegate had with Apple app store submissions. Basically if the app delegate implements these methods, Apple assumes in their static analysis of the submitted apps that you intend to use them, and will warn about requiring the appropriate entitlements to therefore be declared.
Given there's no obvious/easy way to conditionally export these selectors at this time, we are reverting the change to maintain the no warning/no error submission behaviour.
For more information and to track future potential implementations of these lifecycle events, follow: #24237