Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] invalidate shadows on parent's size change #24561

Merged
merged 3 commits into from
Sep 8, 2024

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Sep 1, 2024

Issues Fixed

Fixes #24034
Fixes #24476

Screen.Recording.2024-09-01.at.16.23.17.mov

@kubaflo kubaflo requested a review from a team as a code owner September 1, 2024 14:36
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Sep 1, 2024
Copy link
Contributor

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@kubaflo kubaflo added platform/android 🤖 area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing platform/iOS 🍎 and removed community ✨ Community Contribution labels Sep 1, 2024
Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go, just got a Q about the invalidation for any bounds change or just size.

src/Core/src/Platform/Android/WrapperView.cs Show resolved Hide resolved
@mattleibow
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@kubaflo kubaflo added the community ✨ Community Contribution label Sep 2, 2024
@mattleibow
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen
Copy link
Member

PureWeen commented Sep 8, 2024

Failing iOS test is unrelated and was already fixed on main

@PureWeen PureWeen merged commit c89f12c into dotnet:main Sep 8, 2024
95 of 97 checks passed
@samhouts samhouts added the fixed-in-net9.0-nightly This may be available in a nightly release! label Oct 1, 2024
@samhouts samhouts added fixed-in-9.0.0-rc.2.24503.2 and removed fixed-in-net9.0-nightly This may be available in a nightly release! labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing community ✨ Community Contribution fixed-in-9.0.0-rc.2.24503.2 platform/android 🤖 platform/iOS 🍎
Projects
None yet
4 participants