[xamlc] return early in NodeILExtensions for ValidateOnly
#24493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet@7efca8e Context: xamarin/Xamarin.Forms#7407 For Debug builds, .NET MAUI runs XamlC in a "ValidateOnly" mode, which avoids writing `.dll` files at the end. This way, we get faster builds, but still emit the same errors and warnings that would be emitted in `Release` mode. Right now, the `ValidateOnly` flag is only checked at the end of the process to skip writing files. I looked for some places taking time, such as: 36.30ms (1.1%) microsoft.maui.controls.build.tasks!Microsoft.Maui.Controls.Build.Tasks.NodeILExtensions+<PushServiceProvider>d__12.MoveNext() 20.20ms (0.6%) microsoft.maui.controls.build.tasks!Microsoft.Maui.Controls.Build.Tasks.NodeILExtensions+<PushParentObjectsArray>d__9.MoveNext() 1.21ms (0.0%) microsoft.maui.controls.build.tasks!Microsoft.Maui.Controls.Build.Tasks.NodeILExtensions.PushXmlLineInfo(class Microsoft.Maui.Controls.Xaml.INode,class Microsoft.Maui.Controls.Build.Tasks.ILContext) And added checks to just return early in these methods. With this change in-place, an incremental build of a `dotnet new maui` project template: Before: 1704 ms XamlCTask 4 calls After: 1402 ms XamlCTask 4 calls This probably saves a little less than 100ms per call, but in this example it is running once per platform. This improvement probably will help even more for larger projects with many XAML files.
StephaneDelcroix
approved these changes
Sep 10, 2024
samhouts
added
the
fixed-in-net9.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: 7efca8e
Context: xamarin/Xamarin.Forms#7407
For Debug builds, .NET MAUI runs XamlC in a "ValidateOnly" mode, which avoids writing
.dllfiles at the end. This way, we get faster builds, but still emit the same errors and warnings that would be emitted inReleasemode.Right now, the
ValidateOnlyflag is only checked at the end of the process to skip writing files. I looked for some places taking time, such as:And added checks to just return early in these methods.
With this change in-place, an incremental build of a
dotnet new mauiproject template:This probably saves a little less than 100ms per call, but in this example it is running once per platform. This improvement probably will help even more for larger projects with many XAML files.