Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved Text Jump Issue in Entry Control with HorizontalTextAlignment Set to End #24485

Merged
merged 16 commits into from
Sep 6, 2024

Conversation

BagavathiPerumal
Copy link
Contributor

@BagavathiPerumal BagavathiPerumal commented Aug 28, 2024

Root cause

The root cause of the issue was that the DeleteButton occupied space even when disabled, causing layout issues.

Description of Issue Fix

The solution involves adjusting the “Column” and removing the extra column dynamically based on the button's enabled state, ensuring the layout is correct.

Issues Fixed

Fixes #24405

Output

Before fix:

image

After fix:

image

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Aug 28, 2024
Copy link
Contributor

Hey there @BagavathiPerumal! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@MartyIX
Copy link
Contributor

MartyIX commented Aug 28, 2024

Fixes #24405

This syntax does not make Github to close the issue automatically. The correct syntax is just plaintext:

Fixes #24405

@BagavathiPerumal BagavathiPerumal marked this pull request as ready for review September 3, 2024 12:50
@BagavathiPerumal BagavathiPerumal requested a review from a team as a code owner September 3, 2024 12:50
@jfversluis
Copy link
Member

jfversluis commented Sep 3, 2024

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen enabled auto-merge (squash) September 5, 2024 16:33
@PureWeen
Copy link
Member

PureWeen commented Sep 6, 2024

Failing test unrelated

@PureWeen PureWeen merged commit 9486321 into dotnet:main Sep 6, 2024
95 of 97 checks passed
@samhouts samhouts added the fixed-in-net9.0-nightly This may be available in a nightly release! label Oct 1, 2024
@samhouts samhouts added fixed-in-9.0.0-rc.2.24503.2 and removed fixed-in-net9.0-nightly This may be available in a nightly release! labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows: Entry with right aligned text keeps text jumping to the left during editing
7 participants