Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] moved FlyoutHeaderAdaptsToMinimumHeight to appium #24294

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Aug 18, 2024

Description of Change

FlyoutHeaderAdaptsToMinimumHeight

is failing a good amount. This is a shell based test so let's just move it to Appium where those tend to run a bit more reliably

https://dev.azure.com/xamarin/public/_test/analytics?definitionId=62&contextType=build

Issues Fixed

Fixes #24284

@kubaflo kubaflo requested a review from a team as a code owner August 18, 2024 12:45
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Aug 18, 2024
@kubaflo kubaflo requested a review from PureWeen August 18, 2024 12:46
@PureWeen
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing on Windows FlyoutHeaderAdaptsToMinimumHeight

at Microsoft.Maui.TestCases.Tests.Issues.Issue24284.FlyoutHeaderAdaptsToMinimumHeight() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue24284.cs:line 18

It's a little tricky on windows with these issues because Appium can't find layouts. So, the FlyoutHeader and the Border most likely won't be reachable.

Usually for those cases you can fill the container with a Label or bind the sizes to a label that you can read from in order to get the sizing information

@PureWeen
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen enabled auto-merge (squash) August 23, 2024 18:23
@PureWeen PureWeen merged commit d951f76 into dotnet:main Aug 23, 2024
97 checks passed
@samhouts samhouts added the fixed-in-net8.0-nightly This may be available in a nightly release! label Aug 27, 2024
@samhouts samhouts added the fixed-in-net9.0-nightly This may be available in a nightly release! label Sep 5, 2024
@samhouts samhouts added fixed-in-9.0.0-rc.2.24503.2 and removed fixed-in-net9.0-nightly This may be available in a nightly release! fixed-in-net8.0-nightly This may be available in a nightly release! labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Testing] Resolve FlyoutHeaderAdaptsToMinimumHeight Failures
3 participants