-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Android LoadImageFromFont benchmark and enable verbose Glide logging #24033
Conversation
Hey there @albyrock87! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
@@ -28,7 +28,7 @@ | |||
<Using Include="BenchmarkDotNet.Order" /> | |||
<Using Include="BenchmarkDotNet.Running" /> | |||
<PackageReference Include="BenchmarkDotNet" Version="0.13.10" /> | |||
<PackageReference Include="Xamarin.Android.Glide" Version="4.14.2.1" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version was not in sync with the one we use on all other projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we put the entry here across the repo?
Then you could just put <PackageReference Include="Xamarin.Android.Glide" />
without the Version
across the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I found something better which is already used in the solution $(_XamarinAndroidGlideVersion)
.
Line 92 in 363b626
<_XamarinAndroidGlideVersion>4.15.1.2</_XamarinAndroidGlideVersion> |
@@ -28,7 +28,7 @@ | |||
<Using Include="BenchmarkDotNet.Order" /> | |||
<Using Include="BenchmarkDotNet.Running" /> | |||
<PackageReference Include="BenchmarkDotNet" Version="0.13.10" /> | |||
<PackageReference Include="Xamarin.Android.Glide" Version="4.14.2.1" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we put the entry here across the repo?
Then you could just put <PackageReference Include="Xamarin.Android.Glide" />
without the Version
across the repo.
a254e2d
to
8009ad6
Compare
return IS_VERBOSE_LOGGABLE; | ||
} | ||
|
||
public static void v(String message) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use this in the future to enhance our java glide-related logging.
/azp run |
1 similar comment
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Description of Change
Adds a benchmark for
LoadImageFromFont
on Android platform.Also enables
VERBOSE
logging ofGlide
if requested viaadb
.See #22757 (comment)