Call correct Arrange logic from VE.Arrange #23997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
requested review from
mattleibow and
jsuarezruiz
and removed request for
a team
mattleibow
approved these changes
Aug 5, 2024
|
Why is this against the release branch and not net9.0? |
Because we typically PR against where the release is going and then merge up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Continuing along with this trend, this PR shifts our VisualElement.Arrange to call
IView.ArrangeThe
VE.Arrangein the MAUI code doesn't really do anything with regards to theMAUIlayout system. Setting the Bounds/Frame directly won't really do anything. TheBoundsandFrameon theMAUIlayout system will just get set during theArrangepass on the platform. If you want to influence theboundsorframeyou have to subclass and overrideArrangeOverride.Setting the
Boundsdirectly will really only cause things to happen inside theshims, but, that code will still continue to fire even with this change.Issues Fixed
Fixes #17417