Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android] update AOT profile for .NET 9 Preview 7 #23927

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

jonathanpeppers
Copy link
Member

Context: https://github.com/jonathanpeppers/Mono.Profiler.Android/releases/tag/9.0.0-preview.1

I had to build dotnet/runtime from source and update the Mono.AotProfiler.Android NuGet package for this to work again.

Context: https://github.com/jonathanpeppers/Mono.Profiler.Android/releases/tag/9.0.0-preview.1

I had to build dotnet/runtime from source and update the `Mono.AotProfiler.Android` NuGet package for this to work again.
@rmarinho
Copy link
Member

Is it faster? do we want for the other preview7 pr to merge and run this again ?

@rmarinho
Copy link
Member

/backport to release/9.0.1xx-preview7

Copy link
Contributor

Started backporting to release/9.0.1xx-preview7: https://github.com/dotnet/maui/actions/runs/10178254497

@jonathanpeppers
Copy link
Member Author

do we want for the other preview7 pr to merge and run this again ?

I recorded this profile on a branch using net9.0 + this PR on top:

So, it should be near the "final" Preview 7 build.

Is it faster?

I ran out of time yesterday, will check it today.

@jonathanpeppers
Copy link
Member Author

jonathanpeppers commented Jul 31, 2024

I think it is quite a bit better, dotnet new maui on a Pixel 7:

Before:
Average(ms): 471.1
Std Err(ms): 5.90188293870882
Std Dev(ms): 18.6633925700078
After:
Average(ms): 424
Std Err(ms): 4.40958551844098
Std Dev(ms): 13.9443337755679

I think the .NET 9 profile was last updated like Preview 4 or something.

@lewing
Copy link
Member

lewing commented Jul 31, 2024

@kg put in a lot of work to try to improve wasm startup it is possible some of the improvement is from that

cc @steveisok

@jonathanpeppers
Copy link
Member Author

@lewing it's on my list to compare .NET 8 vs .NET 9, so I don't know the results from that yet.

@rmarinho rmarinho merged commit 1e2fab8 into dotnet:net9.0 Jul 31, 2024
104 of 111 checks passed
@jonathanpeppers jonathanpeppers deleted the net9p7-aotprofile branch July 31, 2024 16:47
@samhouts samhouts added the fixed-in-net9.0-nightly This may be available in a nightly release! label Aug 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-net9.0-nightly This may be available in a nightly release!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants