-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When swapping out ShellItems clear services #23863
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What about adding the Edit: maybe this comment is not even related to this PR. |
PureWeen
force-pushed
the
shell_lifecycle
branch
from
July 29, 2024 01:03
f0b6d9a
to
9d05d89
Compare
PureWeen
force-pushed
the
shell_lifecycle
branch
from
July 29, 2024 16:22
9d05d89
to
52fa36c
Compare
PureWeen
changed the title
[WiP] When swapping out ShellItems clear services
When swapping out ShellItems clear services
Jul 29, 2024
Redth
reviewed
Jul 30, 2024
rmarinho
requested changes
Jul 30, 2024
PureWeen
force-pushed
the
shell_lifecycle
branch
from
July 30, 2024 15:35
963df53
to
b88426c
Compare
rmarinho
approved these changes
Jul 30, 2024
samhouts
added
the
fixed-in-net9.0-nightly
This may be available in a nightly release!
label
Aug 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the user is switching to a new context on shell and they've loaded the ShellContent via the services out. This will clear out the ContentCache so the service will get retrieved again. This allows the users to specify if they want pages to be transient vs persistent.
Rules for clearing out the cache
ShellItem => ShellSection => ShellContent
to not be visible then we'll clear out the cache because the user has indicated that this Page should not longer be part of the active structureScenarios where the cache isn't cleared