Obsolete compatibility layout #23710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
reviewed
Jul 19, 2024
There was a problem hiding this comment.
I think more things should be obsolete since they are not the way we want to do things.
But, I am wondering if people just liked the LayoutChildren override instead of all these other methods? Maybe we add that as a feature to the base layout so people can do this instead?
Do people really have issues with not having all these methods, or just a selection of them? Maybe we can ease the pain, but try move towards a unified/new way instead of adding old back?
Eilon
added
the
area-layout
PureWeen
force-pushed
the
obsolete_compatibility_layout
branch
from
21f2782
to
a873364
Compare
mattleibow
previously approved these changes
Jul 22, 2024
mattleibow
approved these changes
Jul 23, 2024
This was referenced Jul 29, 2024
samhouts
added
the
fixed-in-net9.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
We have a lot of classes that inherit from the compatibility layout which leads to a lot of extra code and workarounds. The compatibility layout also doesn't really play correctly with how the MAUI layout system works.
The motivation here will be to delete this class in a future release of MAUI.
This PR adds a version of Layout that inherits from our new layout but matches the API surface of the compatibility.Layout. In talking with customers, we've seen a number of cases where they don't want to move to the new layout because it doesn't have a generic version and it's a non trivial move because of the API shift.