Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[net9.0][Enhancement] FontImageSource defaults and style #23602

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Jul 14, 2024

Description of Change

    <ContentPage.Resources>
        <Style TargetType="FontImageSource">
            <Setter Property="FontFamily" Value="FA"/>
            <Setter Property="Color" Value="Red"/>
        </Style>
    </ContentPage.Resources>

    <VerticalStackLayout>
        <ImageButton HeightRequest="100" WidthRequest="100" BackgroundColor="Green" Source="{FontImageSource Glyph=''}"/>
        <ImageButton HeightRequest="100" WidthRequest="100" Source="{FontImageSource Color='Black', Glyph=''}"/>
    </VerticalStackLayout>
Screenshot 2024-07-14 at 02 30 32

Issues Fixed

Fixes #13474

@kubaflo kubaflo requested a review from a team as a code owner July 14, 2024 00:37
Copy link
Contributor

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jul 14, 2024
@kubaflo kubaflo added proposal/open area-fonts Custom fonts and Font related API's labels Jul 14, 2024
@kubaflo kubaflo changed the title [Enhancement] FontImageSource defaults and style [net9.0][Enhancement] FontImageSource defaults and style Jul 14, 2024
@rmarinho
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rmarinho
Copy link
Member

/rebase

@github-actions github-actions bot force-pushed the fontimagesource-defaults-and-style branch from 5809314 to 722e81b Compare July 17, 2024 14:56
@rmarinho
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kubaflo can we add a test for this? We can add a xaml unit test and maybe a a screenshot uitest test to make it looks ok at runtime.

@kubaflo
Copy link
Contributor Author

kubaflo commented Jul 17, 2024

@rmarinho Sure, I can add tests on the weekend. The reason I haven't added them is that was that I wasn't sure if you wanted this feature in MAUI :)

@kubaflo kubaflo force-pushed the fontimagesource-defaults-and-style branch from 722e81b to 4ba4c7a Compare July 20, 2024 00:17
@kubaflo
Copy link
Contributor Author

kubaflo commented Jul 20, 2024

@rmarinho I've added a XAML and a UITest

rmarinho
rmarinho previously approved these changes Jul 24, 2024
@StephaneDelcroix
Copy link
Contributor

MergedStyle is set at VisualElement currently. it should probably be set for everything that can get a Style. This is a workaround, and if we go that route, we probably will have to apply it at multiple places

@rmarinho rmarinho added the do-not-merge Don't merge this PR label Jul 24, 2024
Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StephaneDelcroix does this PR make sense to merge?

I can't quite extract from your last comment if you're thinking this is a good way to go.
Sounds like you're thinking we need a little bit more discussion here?

@PureWeen
Copy link
Member

PureWeen commented Sep 4, 2024

/rebase

@github-actions github-actions bot force-pushed the fontimagesource-defaults-and-style branch from 4ba4c7a to a7f3462 Compare September 4, 2024 14:11
@PureWeen
Copy link
Member

PureWeen commented Sep 4, 2024

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@kubaflo kubaflo force-pushed the fontimagesource-defaults-and-style branch from a7f3462 to 9a877cd Compare September 4, 2024 22:54
@PureWeen
Copy link
Member

PureWeen commented Sep 5, 2024

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chatted with @StephaneDelcroix and he gave this one the thumbs up

@PureWeen PureWeen enabled auto-merge (squash) September 5, 2024 16:54
@PureWeen PureWeen merged commit 65afec2 into dotnet:net9.0 Sep 6, 2024
121 checks passed
@samhouts samhouts added the fixed-in-net9.0-nightly This may be available in a nightly release! label Sep 20, 2024
@samhouts samhouts added fixed-in-9.0.0-rc.2.24503.2 and removed fixed-in-net9.0-nightly This may be available in a nightly release! labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-fonts Custom fonts and Font related API's community ✨ Community Contribution do-not-merge Don't merge this PR fixed-in-9.0.0-rc.2.24503.2 proposal/open
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants