Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[net9] BackButtonBehavior enhancement - Changed IsVisible & IsEnabled BindingMode to OneWay #23467

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Jul 6, 2024

Description of Change

By default when the shell was made, all the bindings were set to OneTime because it's supposedly more performant, but it often confuses people. This makes sense because very few things are one-time.

Fixes #19171

@kubaflo kubaflo requested a review from a team as a code owner July 6, 2024 17:20
Copy link
Contributor

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jul 6, 2024
@kubaflo kubaflo added t/enhancement ☀️ New feature or request area-controls-shell Shell Navigation, Routes, Tabs, Flyout labels Jul 6, 2024
@rmarinho
Copy link
Member

rmarinho commented Jul 9, 2024

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen merged commit b80aa7c into dotnet:net9.0 Jul 26, 2024
48 checks passed
@samhouts samhouts added the fixed-in-net9.0-nightly This may be available in a nightly release! label Aug 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout community ✨ Community Contribution fixed-in-net9.0-nightly This may be available in a nightly release! t/enhancement ☀️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants