-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Template Shell Foreground colour #20152
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there @licon4812! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
jsuarezruiz
reviewed
Jan 25, 2024
src/Templates/src/templates/maui-mobile/Resources/Styles/Styles.xaml
Outdated
Show resolved
Hide resolved
davidortinau
changed the title
Updated Shell Foreground colour
Update Template Shell Foreground colour
Jan 26, 2024
Is it possible to revert all the other changes. I was struggling to find the actual change. Thanks! |
@mattleibow done
|
PureWeen
approved these changes
Mar 18, 2024
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-controls-shell
Shell Navigation, Routes, Tabs, Flyout
community ✨
Community Contribution
fixed-in-8.0.20
fixed-in-9.0.0-preview.3.10457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Updated the shell foreground in styles to support Light and dark themes out of the box.
Issues Fixed
Fixes #19178
This PR targets main, although due to it being a tiny 1 line template change, it should be easily backported to older dotnet versions