Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Ensure that viewport calculations for iOS ScrollView account … #18579

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Nov 7, 2023

…for content insets (#18277)"

This reverts commit 0cb5d80.

Description of Change

@hartez is currently reviewing a fix for

#18496
#18513

I'm getting this PR ready and through CI in case we need to revert before he gets a fix

Issues Fixed

Fixes #

@PureWeen PureWeen requested a review from a team as a code owner November 7, 2023 17:33
@PureWeen PureWeen requested review from mattleibow and rmarinho and removed request for a team November 7, 2023 17:33
@rmarinho
Copy link
Member

rmarinho commented Nov 7, 2023

Why are we reverting this , can we add some context to the PR ?

@PureWeen PureWeen enabled auto-merge (squash) November 7, 2023 20:04
@PureWeen PureWeen merged commit 1ebb238 into release/8.0.1xx Nov 7, 2023
6 checks passed
@PureWeen PureWeen deleted the revert_18277 branch November 7, 2023 20:09
@PureWeen
Copy link
Member Author

PureWeen commented Nov 9, 2023

/backport to net8.0

Copy link
Contributor

github-actions bot commented Nov 9, 2023

Started backporting to net8.0: https://github.com/dotnet/maui/actions/runs/6810374004

@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2023
@samhouts samhouts added the fixed-in-8.0.3 Look for this fix in 8.0.3 label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-8.0.3 Look for this fix in 8.0.3 platform/iOS 🍎
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants