Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[X] connect the right method to the event handler #18043

Merged
merged 1 commit into from
Oct 19, 2023
Merged

[X] connect the right method to the event handler #18043

merged 1 commit into from
Oct 19, 2023

Conversation

StephaneDelcroix
Copy link
Contributor

Description of Change

[X] connect the right method to the event handler

Issues Fixed

@StephaneDelcroix StephaneDelcroix requested a review from a team as a code owner October 16, 2023 11:47
@samhouts samhouts added this to the .NET 8 GA milestone Oct 16, 2023
samhouts
samhouts previously approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@samhouts samhouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we happen to know what regressed this?

src/Controls/src/Xaml/ApplyPropertiesVisitor.cs Show resolved Hide resolved
rmarinho
rmarinho previously approved these changes Oct 17, 2023
View reviewed changes
@StephaneDelcroix
Copy link
Contributor Author

StephaneDelcroix commented Oct 17, 2023 •
edited
Loading

Do we happen to know what regressed this?

we probably did not regress, unless there was a change in .net7 vs .net8 reflection code

@hartez hartez removed their request for review October 18, 2023 14:48
@rmarinho rmarinho merged commit 8ef1aec into net8.0 Oct 19, 2023
47 checks passed
@rmarinho rmarinho deleted the fix_17950 branch October 19, 2023 15:12
@PureWeen
Copy link
Member

/backport to release/8.0.1xx-rc2

@github-actions
Copy link
Contributor

Started backporting to release/8.0.1xx-rc2: https://github.com/dotnet/maui/actions/runs/6628494797

@github-actions github-actions bot mentioned this pull request Oct 24, 2023
Closed
@PureWeen
Copy link
Member

/backport to release/8.0.1xx-rc2.1

@github-actions
Copy link
Contributor

Started backporting to release/8.0.1xx-rc2.1: https://github.com/dotnet/maui/actions/runs/6628701756

@github-actions github-actions bot mentioned this pull request Oct 24, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
@samhouts samhouts added the fixed-in-8.0.0-rc.2.9511 Look for this fix in 8.0.0-rc.2.9511 label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

@rmarinho rmarinho rmarinho approved these changes

@samhouts samhouts samhouts left review comments

@rachelkang rachelkang Awaiting requested review from rachelkang rachelkang is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
fixed-in-8.0.0-rc.2.9511 Look for this fix in 8.0.0-rc.2.9511
Projects
None yet
Milestone
.NET 8 GA
Development

Successfully merging this pull request may close these issues.
5 participants
@StephaneDelcroix @PureWeen @rmarinho @jsuarezruiz @samhouts