Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WinUI Tests #17539

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Fix WinUI Tests #17539

merged 1 commit into from
Sep 21, 2023

Conversation

PureWeen
Copy link
Member

Description of Change

#17041 changed the order SetWindow so that it's available inside OnCreateWindow. This made the extra call here inside our stub not necessary.

This was caught by #17221 which we'll hopefully get merged tomorrow. :-)

@PureWeen PureWeen requested a review from a team as a code owner September 21, 2023 02:07
@PureWeen PureWeen enabled auto-merge (squash) September 21, 2023 02:08
@PureWeen PureWeen merged commit 27c7df9 into main Sep 21, 2023
45 checks passed
@PureWeen PureWeen deleted the fix_winui_tests branch September 21, 2023 08:39
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
@samhouts samhouts added the fixed-in-8.0.0-rc.2.9373 Look for this fix in 8.0.0-rc.2.9373! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-8.0.0-rc.2.9373 Look for this fix in 8.0.0-rc.2.9373!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants