Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Update main with latest changes for internal builds #17255

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

rmarinho
Copy link
Member

@rmarinho rmarinho commented Sep 7, 2023

Description of Change

Update pipeline with latest changes to build with internal


- ${{ each step in parameters.prepareSteps }}:
- ${{ each pair in step }}:
${{ pair.key }}: ${{ pair.value }}

- task: PowerShell@2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is moved here for builds on dotnet-maui pipeline

@Eilon Eilon added the area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions label Sep 7, 2023
@rmarinho rmarinho requested a review from Eilon September 7, 2023 17:49
@Eilon
Copy link
Member

Eilon commented Sep 8, 2023

Is this part of updating things to be more .NET-eng-ish?

@rmarinho
Copy link
Member Author

rmarinho commented Sep 8, 2023

Is this part of updating things to be more .NET-eng-ish?

Yes exactly, bring that work to all branches so we can use if we need.

@rmarinho rmarinho requested review from samhouts and removed request for StephaneDelcroix September 8, 2023 17:09
@rmarinho rmarinho added the do-not-merge Don't merge this PR label Sep 8, 2023
Eilon
Eilon previously approved these changes Sep 8, 2023
@rmarinho rmarinho removed the do-not-merge Don't merge this PR label Sep 10, 2023
@rmarinho rmarinho merged commit 9a9537e into main Sep 11, 2023
39 checks passed
@rmarinho rmarinho deleted the update-builds-internal branch September 11, 2023 12:55
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2023
@samhouts samhouts added the fixed-in-8.0.0-rc.2.9373 Look for this fix in 8.0.0-rc.2.9373! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions fixed-in-8.0.0-rc.2.9373 Look for this fix in 8.0.0-rc.2.9373!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants