Add View docs #17220
Merged
Add View docs #17220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
requested changes
Sep 6, 2023
Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com>
jfversluis
approved these changes
Sep 6, 2023
jfversluis
added
the
backport/suggested
|
Suggesting backport because it's relatively safe to do and gives up more coverage on the docs in vCurrent |
|
/backport to release/8.0.1xx-rc2.2 |
|
Started backporting to release/8.0.1xx-rc2.2: https://github.com/dotnet/maui/actions/runs/6631841696 |
|
@PureWeen backporting to release/8.0.1xx-rc2.2 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: [docs] Document View
.git/rebase-apply/patch:527: trailing whitespace.
/// Invoked whenever the binding context of the <see cref="View" /> changes.
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
A src/Controls/docs/Microsoft.Maui.Controls/View.xml
M src/Controls/src/Core/View/View.cs
Falling back to patching base and 3-way merge...
Auto-merging src/Controls/src/Core/View/View.cs
CONFLICT (content): Merge conflict in src/Controls/src/Core/View/View.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 [docs] Document View
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@PureWeen an error occurred while backporting to release/8.0.1xx-rc2.2, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Add docs for View
Issues Fixed
Related to #3960