Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[net7.0] [iOS] Fix ScrollTo method issues #17093

Merged
merged 4 commits into from
Sep 20, 2023
Merged

Conversation

hartez
Copy link
Contributor

@hartez hartez commented Aug 30, 2023

Backport of #15984 to net7.0

/cc @hartez @jsuarezruiz

@jfversluis jfversluis assigned jfversluis and unassigned jfversluis Aug 30, 2023
Copy link
Member

@jfversluis jfversluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D:\a_work\1\s\src\Core\src\Handlers\ScrollView\ScrollViewHandler.iOS.cs(18,12): error CS0246: The type or namespace name 'ScrollEventProxy' could not be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Core\src\Core.csproj::TargetFramework=net7.0-maccatalyst]
D:\a_work\1\s\src\Core\src\Handlers\ScrollView\ScrollViewHandler.iOS.cs(18,12): error CS0246: The type or namespace name 'ScrollEventProxy' could not be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Core\src\Core.csproj::TargetFramework=net7.0-ios]

@samhouts samhouts added this to the .NET 7 + Servicing milestone Aug 30, 2023
@Eilon Eilon added the area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter label Aug 30, 2023
@samhouts samhouts added the s/pr-needs-author-input PR needs an update from the author label Sep 11, 2023
@ghost
Copy link

ghost commented Sep 11, 2023

Hi @hartez. We have added the "s/pr-needs-author-input" label to this issue, which indicates that we have an open question/action for you before we can take further action. This PRwill be closed automatically in 14 days if we do not hear back from you by then - please feel free to re-open it if you come back to this PR after that time.

* Fix iOS ScrollTo issues

---------

Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com>
@PureWeen PureWeen enabled auto-merge (squash) September 19, 2023 18:29
@rmarinho rmarinho merged commit 6a0d8fb into net7.0 Sep 20, 2023
27 of 30 checks passed
@rmarinho rmarinho deleted the backport/pr-15984-to-net7.0 branch September 20, 2023 13:12
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2023
@samhouts samhouts added the fixed-in-7.0.96 Look for this fix in 7.0.96 SR8! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter fixed-in-7.0.96 Look for this fix in 7.0.96 SR8! platform/iOS 🍎 s/pr-needs-author-input PR needs an update from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants