Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert adding Windows DeviceTests to .NET 7 #16970

Merged
merged 5 commits into from
Aug 24, 2023
Merged

Conversation

jfversluis
Copy link
Member

@jfversluis jfversluis commented Aug 24, 2023

Initially we thought some flaky test errors on the .NET 7 branch while merging the device tests had a different cause. Turns out it is caused by the change in #16756 after all.

There is too much that needs to be backported (and figured out first) from the main branch to bring back to .NET 7. Let's revert this and focus on improving on vNext and beyond.

@jfversluis jfversluis changed the base branch from main to net7.0 August 24, 2023 08:51
@jfversluis jfversluis changed the title [NET7] Fix DeviceTests Revert adding Windows DeviceTests to .NET 7 Aug 24, 2023
@jfversluis jfversluis marked this pull request as ready for review August 24, 2023 11:08
@jfversluis jfversluis requested a review from a team as a code owner August 24, 2023 11:08
@rmarinho rmarinho enabled auto-merge (squash) August 24, 2023 12:52
@jfversluis jfversluis merged commit 6f75ecf into net7.0 Aug 24, 2023
29 checks passed
@jfversluis jfversluis deleted the fix-devicetests branch August 24, 2023 12:59
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
@samhouts samhouts added the fixed-in-7.0.96 Look for this fix in 7.0.96 SR8! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing Unit tests, device tests fixed-in-7.0.96 Look for this fix in 7.0.96 SR8! platform/windows 🪟 t/housekeeping ♻︎
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants