Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obsolete VisualElement.FocusChangeRequested event #16750

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Obsolete VisualElement.FocusChangeRequested event #16750

merged 1 commit into from
Aug 15, 2023

Conversation

jfversluis
Copy link
Member

Description of Change

As indicated by a todo in code, obsoletes the VisualElement.FocusChangeRequested event. This is now handled through the VisualElement mapper with MapFocus by setting the IView.Focus property.

Issues Fixed

Fixes #14299

@jfversluis jfversluis added t/breaking 💥 legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor labels Aug 15, 2023
@jfversluis jfversluis requested a review from a team as a code owner August 15, 2023 08:34
@ghost
Copy link

ghost commented Aug 15, 2023

🚨 API change(s) detected @davidbritch FYI

@PureWeen PureWeen enabled auto-merge (squash) August 15, 2023 10:14
@PureWeen PureWeen disabled auto-merge August 15, 2023 10:14
@PureWeen PureWeen enabled auto-merge (squash) August 15, 2023 10:14
@PureWeen PureWeen merged commit 48e5caa into main Aug 15, 2023
39 checks passed
@PureWeen PureWeen deleted the fix-14299 branch August 15, 2023 12:15
rmarinho pushed a commit that referenced this pull request Aug 19, 2023
@jfversluis @rmarinho
Obsolete VisualElement.FocusChangeRequested event (#16750)
89f90f6
@davidbritch davidbritch mentioned this pull request Sep 26, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2023
@Eilon Eilon added area-controls-general General issues that span multiple controls, or common base classes such as View or Element and removed legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor labels May 13, 2024
@samhouts samhouts added the fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171 label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PureWeen PureWeen PureWeen approved these changes

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@hartez hartez Awaiting requested review from hartez hartez is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@rachelkang rachelkang Awaiting requested review from rachelkang

Assignees
No one assigned
Labels
area-controls-general General issues that span multiple controls, or common base classes such as View or Element fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171 t/breaking 💥 t/housekeeping ♻︎
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Obsolete FocusChangeRequested
4 participants
@jfversluis @PureWeen @Eilon @samhouts