Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Add updates for LineHeight, TextDecorations, CharacterSpacing #16223

Merged
merged 5 commits into from
Aug 3, 2023

Conversation

cat0363
Copy link
Contributor

@cat0363 cat0363 commented Jul 19, 2023

Description of Change

This PR fixes the problem that the LineHeight, TextDecorations, CharacterSpacing properties are not reflected when the label is displayed for the first time.

Called the MapFormatting method of LabelHandler in the MapFormatting method of Label.iOS.cs so that the values ​​of LineHeight, TextDecorations, and CharacterSpacing are reflected. I used a similar condition because LineHeight, TextDecorations, CharacterSpacing were updating only when the Text set on the Label was PlainText.

[src\Controls\src\Core\Label\Label.iOS.cs]

static void MapFormatting(ILabelHandler handler, Label label)
{
    handler.UpdateValue(nameof(ILabel.TextColor));
    handler.UpdateValue(nameof(ILabel.Font));

    if (!IsPlainText(label))
        return;

    LabelHandler.MapFormatting(handler, label);
}

Issues Fixed

Fixes #16204

Below is the execution result.

2023-07-19_12-36-41-午後

@ghost ghost added the community ✨ Community Contribution label Jul 19, 2023
@ghost
Copy link

ghost commented Jul 19, 2023

Hey there @cat0363! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@cat0363 cat0363 changed the title Add updates for LineHeight, TextDecorations, CharacterSpacing [iOS] Add updates for LineHeight, TextDecorations, CharacterSpacing Jul 19, 2023
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 19, 2023
@cat0363 cat0363 requested a review from jknaudt21 July 25, 2023 04:28
@rmarinho
Copy link
Member

rmarinho commented Aug 1, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rmarinho rmarinho merged commit 800b5b0 into dotnet:main Aug 3, 2023
39 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
@samhouts samhouts added the fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171 label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-label Label, Span community ✨ Community Contribution fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171 platform/iOS 🍎
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LineHeight, CharacterSpacing, TextDecorations property not working when Label is first displayed on iOS.
6 participants