-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Add updates for LineHeight, TextDecorations, CharacterSpacing #16223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there @cat0363! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
cat0363
changed the title
Add updates for LineHeight, TextDecorations, CharacterSpacing
[iOS] Add updates for LineHeight, TextDecorations, CharacterSpacing
Jul 19, 2023
jsuarezruiz
reviewed
Jul 19, 2023
ghost
added
the
legacy-area-controls
Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor
label
Jul 19, 2023
jsuarezruiz
approved these changes
Jul 20, 2023
jknaudt21
reviewed
Jul 20, 2023
src/Controls/tests/DeviceTests/Elements/Label/LabelTests.iOS.cs
Outdated
Show resolved
Hide resolved
jknaudt21
approved these changes
Jul 25, 2023
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Eilon
removed
the
legacy-area-controls
Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor
label
May 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-controls-label
Label, Span
community ✨
Community Contribution
fixed-in-8.0.0-rc.1.9171
Look for this fix in 8.0.0-rc.1.9171
platform/iOS 🍎
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR fixes the problem that the LineHeight, TextDecorations, CharacterSpacing properties are not reflected when the label is displayed for the first time.
Called the MapFormatting method of LabelHandler in the MapFormatting method of Label.iOS.cs so that the values of LineHeight, TextDecorations, and CharacterSpacing are reflected. I used a similar condition because LineHeight, TextDecorations, CharacterSpacing were updating only when the Text set on the Label was PlainText.
[src\Controls\src\Core\Label\Label.iOS.cs]
Issues Fixed
Fixes #16204
Below is the execution result.