Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Avoid to use CornerCurve in iOS < 13 #16101

Merged
merged 1 commit into from
Jul 13, 2023
Merged

[iOS] Avoid to use CornerCurve in iOS < 13 #16101

merged 1 commit into from
Jul 13, 2023

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Jul 12, 2023

Description of Change

Avoid to use CornerCurve in iOS < 13.

Issues Fixed

Fixes #16097

@jsuarezruiz jsuarezruiz added t/bug Something isn't working platform/iOS 🍎 high It doesn't work at all, crashes or has a big impact. labels Jul 12, 2023
@jfversluis
Copy link
Member

jfversluis commented Jul 12, 2023

Does this impact the working at all? Like, this change was implemented for a reason. Does that functionality now work different on iOS < 13? @jsuarezruiz

@jsuarezruiz
Copy link
Contributor Author

Does this impact the working at all? Like, this change was implemented for a reason. Does that functionality now work different on iOS < 13? @jsuarezruiz

Good question. Yes, it will continue to work even without applying this property. Mainly, it helps if you change or animate the corners of a RoundRectangle in a continuous, smooth way, although it is not essential.

@jfversluis jfversluis merged commit ed18303 into main Jul 13, 2023
27 checks passed
@jfversluis jfversluis deleted the fix-16097 branch July 13, 2023 17:58
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
@samhouts samhouts added the fixed-in-8.0.0-preview.7.8842 Look for this fix in 8.0.0-preview.7.8842! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-8.0.0-preview.7.8842 Look for this fix in 8.0.0-preview.7.8842! high It doesn't work at all, crashes or has a big impact. platform/iOS 🍎 t/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[regression/8.0.0] Blank .NET MAUI App crashes on iOS 12 device with .NET 8 preview 6
3 participants