-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] Fix Slider MinimumTrackColor (#16056) #16057
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix typo that prevents MinimumTackColor being mapped to SliderTrackValueFillPointerOver on WinUI 3
Hey there @molesmoke! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
This should probably be moved/cherry-picked to the relevant release branches as appropriate (e.g release/7.0.2xx-sr7) |
jsuarezruiz
approved these changes
Jul 10, 2023
ghost
added
the
legacy-area-controls
Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor
label
Jul 10, 2023
jsuarezruiz
added
platform/windows 🪟
and removed
legacy-area-controls
Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor
labels
Jul 10, 2023
/azp run |
No commit pushedDate could be found for PR 16057 in repo dotnet/maui |
jfversluis
approved these changes
Jul 10, 2023
Eilon
added
the
legacy-area-controls
Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor
label
Jul 10, 2023
nice catch! |
Azure Pipelines successfully started running 2 pipeline(s). |
Eilon
removed
the
legacy-area-controls
Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor
label
May 10, 2024
samhouts
added
the
fixed-in-8.0.0-preview.7.8842
Look for this fix in 8.0.0-preview.7.8842!
label
Aug 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-controls-slider
Slider
community ✨
Community Contribution
fixed-in-8.0.0-preview.7.8842
Look for this fix in 8.0.0-preview.7.8842!
platform/windows 🪟
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix typo that prevents MinimumTackColor being mapped to SliderTrackValueFillPointerOver on WinUI 3
Issues Fixed
Fixes #16056