Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Fix Slider MinimumTrackColor (#16056) #16057

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Conversation

molesmoke
Copy link
Contributor

Description of Change

Fix typo that prevents MinimumTackColor being mapped to SliderTrackValueFillPointerOver on WinUI 3

Issues Fixed

Fixes #16056

Fix typo that prevents MinimumTackColor being mapped to
SliderTrackValueFillPointerOver on WinUI 3
@ghost ghost added the community ✨ Community Contribution label Jul 10, 2023
@ghost
Copy link

ghost commented Jul 10, 2023

Hey there @molesmoke! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@molesmoke
Copy link
Contributor Author

This should probably be moved/cherry-picked to the relevant release branches as appropriate (e.g release/7.0.2xx-sr7)

@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 10, 2023
@jsuarezruiz jsuarezruiz added platform/windows 🪟 and removed legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor labels Jul 10, 2023
@jfversluis
Copy link
Member

jfversluis commented Jul 10, 2023

/azp run

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 16057 in repo dotnet/maui

@Eilon Eilon added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 10, 2023
@rachelkang
Copy link
Member

nice catch!

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jfversluis jfversluis enabled auto-merge (squash) July 14, 2023 09:43
@jfversluis jfversluis merged commit 95583f7 into dotnet:main Jul 14, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
@samhouts samhouts added the fixed-in-8.0.0-preview.7.8842 Look for this fix in 8.0.0-preview.7.8842! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-slider Slider community ✨ Community Contribution fixed-in-8.0.0-preview.7.8842 Look for this fix in 8.0.0-preview.7.8842! platform/windows 🪟
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slider MinimumTrackColor has no effect on Windows
7 participants