Fix ".SFUI" magic font string on iOS/MacCatalyst #15990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason `UIFont.FromName` always returns _some_ font even if you specify an invalid name, but it may not be the _correct_ font. There was some logic added in MAUI to clean up the font name and try and load by the cleaned up name, however since `UIFont.FromName` always returns a result and not null, it will always be used before we would even get to checking the ".SFUI" magic string. This also probably means the final attempt to get a font by (non cleaned up) name actually never gets hit, but for now this is still an improvement.
|
/azp run |
jsuarezruiz
added
area-fonts
|
Azure Pipelines successfully started running 2 pipeline(s). |
jsuarezruiz
approved these changes
Jul 5, 2023
jfversluis
approved these changes
Jul 5, 2023
mattleibow
approved these changes
Jul 5, 2023
samhouts
added
the
fixed-in-8.0.0-preview.7.8842
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason
UIFont.FromNamealways returns some font even if you specify an invalid name, but it may not be the correct font.There was some logic added in MAUI to clean up the font name and try and load by the cleaned up name, however since
UIFont.FromNamealways returns a result and not null, it will always be used before we would even get to checking the ".SFUI" magic string.This also probably means the final attempt to get a font by (non cleaned up) name actually never gets hit, but for now this is still an improvement.
Fixes #15882