[ios] fix memory leak in Border #15946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet#14664 Context: https://github.com/nacompllo/MemoryLeakEverywhere/tree/bugfix/memoryLeakItemsSource While looking at the customer sample, we found an issue with `BorderHandler`: * `ContentView` -> via `LayoutSubviewsChanged` * `BorderHandler` -> * `ContentView` Creating a cycle & memory leak on iOS and Catalyst. We could reproduce this in a device test. It appears the event only did this: void OnLayoutSubviewsChanged(object? sender, EventArgs e) { PlatformView?.UpdateMauiCALayer(); } And so instead, we can just call the extension method directly: this.UpdateMauiCALayer(); And the leak is gone! Co-authored-by: Haritha Mohan <harithamohan@microsoft.com>
jonathanpeppers
added
platform/iOS 🍎
legacy-area-perf
jstedfast
approved these changes
Jun 30, 2023
jknaudt21
approved these changes
Jun 30, 2023
4 tasks
jonathanpeppers
added
memory-leak 💦
21 tasks
samhouts
added
the
fixed-in-8.0.0-preview.7.8842
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #14664
Context: https://github.com/nacompllo/MemoryLeakEverywhere/tree/bugfix/memoryLeakItemsSource
While looking at the customer sample, we found an issue with
BorderHandler:ContentView-> viaLayoutSubviewsChangedBorderHandler->ContentViewCreating a cycle & memory leak on iOS and Catalyst. We could reproduce this in a device test.
It appears the event only did this:
And so instead, we can just call the extension method directly:
And the leak is gone!
We are not sure if #14664 will be fully solved by this change, but it is one issue in the sample.