[X] Compiled Bindings to Array #15944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emit ldelem opcodes for accessing arrays elements in compiled bindings
jstedfast
approved these changes
Jun 30, 2023
| @@ -719,7 +737,7 @@ static IEnumerable<Instruction> CompiledBindingGetSetter(TypeReference tSourceRe | |||
| setter.Body.InitLocals = true; | |||
|
|
|||
| var il = setter.Body.GetILProcessor(); | |||
| if (!properties.Any() || properties.Last().property.SetMethod == null) | |||
| if (!properties.Any() || properties.Last().property == null || properties.Last().property.SetMethod == null) | |||
There was a problem hiding this comment.
You could simplify this to something like:
Suggested change
| if (!properties.Any() || properties.Last().property == null || properties.Last().property.SetMethod == null) | |
| if (properties.Last() is ThePropertyType p && p.property == null || p.property.SetMethod == null) |
Which could avoid calling Any() and Last() as many times.
There was a problem hiding this comment.
you mean LastOrDefault ?
| else | ||
| throw new BuildException(BindingIndexerParse, lineInfo, null, indexArg, property.Name); | ||
| { | ||
| var indexType = property.GetMethod.Parameters[0].ParameterType.ResolveGenericParameters(propDeclTypeRef); |
There was a problem hiding this comment.
This would be terrible to do in practice... But can you make C# indexers with multiple parameters?
public string this[string key1, string key2]
{
get => someTupleDictionary[(key1, key2)];
set => someTupleDictionary[(key1, key2)] = value;
}There was a problem hiding this comment.
well, this PR is about arrays, not indexers, but yeah, it doesn't cover multidimensional arrays 🙉🙉🙉
samhouts
added
the
fixed-in-8.0.0-preview.7.8842
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
emit ldelem opcodes for accessing arrays elements in compiled bindings
Issues Fixed
Fixes #10396