Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[net7.0] Handle Grid * expansion when size is larger than minimum, but less than sufficient to display full size #15653

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

hartez
Copy link
Contributor

@hartez hartez commented Jun 14, 2023

Backport of #14902 to net7.0

/cc @hartez

…an sufficient to display full size (#14902)

* Add tests for overlapping stuff, checkpoint before working out the multiple arrange stuff

* Working, just needs a lot of cleanup

* More cleanup

* Break down decompress method

* Add test for multiple Arrange calls

* More comprehensive test for multiple Arrange calls

* No longer need the Available* methods

* Pare down star decompression

* Fix empty star row/column error

* Make the grid structure methods clearer in their purpose

* Remove return from ResolveStars

* Auto-format source code

* Account for greedy control measurement behavior

* Auto-format source code

* Remove extraneous using

* Prevent unnecessary LayoutSubviews in xplat backing controls

---------

Co-authored-by: GitHub Actions Autoformatter <autoformat@example.com>
@rmarinho rmarinho merged commit 8f0c2a8 into net7.0 Jun 15, 2023
@rmarinho rmarinho deleted the backport/pr-14902-to-net7.0 branch June 15, 2023 10:40
PureWeen added a commit that referenced this pull request Jun 28, 2023
… less than sufficient to display full size (#14902) (#15653)"

This reverts commit 8f0c2a8.
github-actions bot pushed a commit that referenced this pull request Jun 28, 2023
… less than sufficient to display full size (#14902) (#15653)"

This reverts commit 8f0c2a8.
rmarinho pushed a commit that referenced this pull request Jun 29, 2023
… less than sufficient to display full size (#14902) (#15653)" (#15915)

This reverts commit 8f0c2a8.
rmarinho pushed a commit that referenced this pull request Jun 29, 2023
… less than sufficient to display full size (#14902) (#15653)" (#15917)

This reverts commit 8f0c2a8.

Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
@samhouts samhouts added the fixed-in-7.0.92 Look for this fix in 7.0.92! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-7.0.92 Look for this fix in 7.0.92! t/housekeeping ♻︎
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants