Fix sizing issues with CollectionView on Windows #15587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
rmarinho
approved these changes
Jun 15, 2023
StephaneDelcroix
pushed a commit
that referenced
this pull request
Jun 19, 2023
samhouts
added
the
fixed-in-8.0.0-preview.6.8686
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes the ignored tests from #15530.
Removes a extra 10-point padding from the bottom of the backing GridView used for the CollectionView.
Updates the logic for updating the scrollbar visibility in the CollectionView to preserve the default value from the control template. This prevents the vertical scrollbar from being made always visible by default (rather than the intended default of
Auto).This won't prevent the ultimate issue of the default being corrupted if the user sets a non-default value in the cross-platform code, but it will prevent the most common problem (the default being set to
Visibleinstead ofAutowhen the user tries to use the defaults).