Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements Color.Equal() correctly #15218

Merged
merged 2 commits into from
May 24, 2023
Merged

Conversation

jstedfast
Copy link
Member

@jstedfast jstedfast commented May 22, 2023

Description of Change

Fixes Color.Equal() to compare integer values instead of floating point values (with a large epsilon) for equality.

Issues Fixed

Fixes issue #13968

@jstedfast jstedfast enabled auto-merge May 23, 2023 16:26
@Eilon Eilon added the area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing label May 23, 2023
@jstedfast jstedfast merged commit c88c07d into main May 24, 2023
@jstedfast jstedfast deleted the dev/jestedfa/color-equal-fix branch May 24, 2023 11:23
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2023
@samhouts samhouts added the fixed-in-8.0.0-preview.5.8529 Look for this fix in 8.0.0-preview.5.8529! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing fixed-in-8.0.0-preview.5.8529 Look for this fix in 8.0.0-preview.5.8529!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants